Skip to content

ref(js): Remove ModalStore calls from tests #98054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

ref(js): Remove ModalStore calls from tests #98054

merged 1 commit into from
Aug 25, 2025

Conversation

@evanpurkhiser
Copy link
Member

Any open modals will now always be closed for tests

@evanpurkhiser evanpurkhiser requested review from a team as code owners August 20, 2025 16:41
@evanpurkhiser evanpurkhiser removed request for a team August 20, 2025 16:41
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

❌ 21 Tests Failed:

Tests completed Failed Passed Skipped
11440 21 11419 10
View the top 3 failed test(s) by shortest run time 
eventViewToWidgetQuery updates orderby to function format for top N query
Stack Traces | 0.004s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Error: Not implemented: navigation (except hash changes)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:9:17)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7) {
  type: 'not implemented'
}
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at VirtualConsole.<anonymous> (.../sentry/node_modules/.pnpm/@[email protected][email protected]/node_modules/@.../environment-jsdom-abstract/build/index.js:78:23)
    at VirtualConsole.emit (node:events:518:28)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:12:26)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)
    at flushUnexpectedConsoleCalls (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:145:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusHook (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:978:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:951:5)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)
downloadAsCsv quotes unsafe strings
Stack Traces | 0.006s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Error: Not implemented: navigation (except hash changes)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:9:17)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7) {
  type: 'not implemented'
}
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at VirtualConsole.<anonymous> (.../sentry/node_modules/.pnpm/@[email protected][email protected]/node_modules/@.../environment-jsdom-abstract/build/index.js:78:23)
    at VirtualConsole.emit (node:events:518:28)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:12:26)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)
    at flushUnexpectedConsoleCalls (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:145:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusHook (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:978:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:951:5)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)
downloadAsCsv handles the user column
Stack Traces | 0.007s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Error: Not implemented: navigation (except hash changes)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:9:17)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7) {
  type: 'not implemented'
}
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at VirtualConsole.<anonymous> (.../sentry/node_modules/.pnpm/@[email protected][email protected]/node_modules/@.../environment-jsdom-abstract/build/index.js:78:23)
    at VirtualConsole.emit (node:events:518:28)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:12:26)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)

Error: Not implemented: navigation (except hash changes)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:9:17)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7) {
  type: 'not implemented'
}
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at VirtualConsole.<anonymous> (.../sentry/node_modules/.pnpm/@[email protected][email protected]/node_modules/@.../environment-jsdom-abstract/build/index.js:78:23)
    at VirtualConsole.emit (node:events:518:28)
    at module.exports (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/not-implemented.js:12:26)
    at navigateFetch (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:77:3)
    at exports.navigate (.../sentry/node_modules/.pnpm/[email protected]..../living/window/navigation.js:55:3)
    at Timeout._onTimeout (.../sentry/node_modules/.pnpm/[email protected]..../living/nodes/HTMLHyperlinkElementUtils-impl.js:80:7)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)
    at flushUnexpectedConsoleCalls (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:145:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusHook (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:978:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:951:5)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scttcper
Copy link
Member

i'd be surprised if there weren't a bunch of failing tests from this

@evanpurkhiser
ref(js): Remove ModalStore calls from tests
eb3b15b 
Any open modals will now always be closed for tests
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-js-remove-modalstore-calls-from-tests branch from d6f9324 to eb3b15b Compare August 21, 2025 19:23
cursor[bot]
cursor bot reviewed Aug 21, 2025
View reviewed changes
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) August 21, 2025 22:14
@evanpurkhiser evanpurkhiser merged commit 55be306 into master Aug 25, 2025
45 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-remove-modalstore-calls-from-tests branch August 25, 2025 10:46
lzhao-sentry pushed a commit that referenced this pull request Aug 25, 2025
@evanpurkhiser @lzhao-sentry
ref(js): Remove ModalStore calls from tests (#98054)
8bda18c 
Any open modals will now always be closed for tests
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
@evanpurkhiser @andrewshie-sentry
ref(js): Remove ModalStore calls from tests (#98054)
52a8c38 
Any open modals will now always be closed for tests
constantinius pushed a commit that referenced this pull request Sep 1, 2025
@evanpurkhiser @constantinius
ref(js): Remove ModalStore calls from tests (#98054)
6c7f745 
Any open modals will now always be closed for tests
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@scttcper scttcper scttcper approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanpurkhiser @scttcper